ring_buffer_subbuf_order_set() checks for resize_disabled twice under the same buffer->mutex hold. Moreover, this check duplicates the logic in ring_buffer_resize(). Create a common helper rb_resize_disabled() to factor out this code and drop redundant checks.
Additionally, remove the unnecessary cpumask_test_cpu() in ring_buffer_subbuf_order_set() as for_each_buffer_cpu() already iterates over buffer->cpumask. v2: - Split cpumask_test_cpu() cleanup into its own patch (Steven) - Remove another unnecessary cpumask_test_cpu() (David) v1: https://lore.kernel.org/all/[email protected]/ Vincent Donnefort (2): ring-buffer: Clean up resize_disabled checks ring-buffer: Remove unnecessary cpumask_test_cpu kernel/trace/ring_buffer.c | 70 +++++++++++++++----------------------- 1 file changed, 28 insertions(+), 42 deletions(-) base-commit: fd73f4a6659897191fa0d40695fe370925dd3780 -- 2.55.0.1082.g2b9226bbc0-goog
