The inode_setsecctx hook receives a struct path, so rename it to path_setsecctx to follow the path_* naming convention used for the other hooks that take a struct path (path_chmod, path_chown, ...). Rename the security_inode_setsecctx() inline wrapper to security_path_setsecctx() and the SELinux and Smack implementations accordingly.
Assisted-by: opencode: glm-5.3 Signed-off-by: Cai Xinchen <[email protected]> --- fs/nfsd/vfs.c | 2 +- include/linux/lsm_hook_defs.h | 2 +- include/linux/security.h | 4 ++-- security/security.c | 8 ++++---- security/selinux/hooks.c | 4 ++-- security/smack/smack_lsm.c | 4 ++-- 6 files changed, 12 insertions(+), 12 deletions(-) diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index 5ae540bf0b9a..eb7dee641612 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c @@ -627,7 +627,7 @@ nfsd_setattr(struct svc_rqst *rqstp, struct svc_fh *fhp, break; } if (attr->na_seclabel && attr->na_seclabel->len) - attr->na_labelerr = security_inode_setsecctx(&path, + attr->na_labelerr = security_path_setsecctx(&path, attr->na_seclabel->data, attr->na_seclabel->len); if (IS_ENABLED(CONFIG_FS_POSIX_ACL) && attr->na_dpacl) { if (!S_ISDIR(inode->i_mode)) diff --git a/include/linux/lsm_hook_defs.h b/include/linux/lsm_hook_defs.h index da490923cdcd..9ea096505ef1 100644 --- a/include/linux/lsm_hook_defs.h +++ b/include/linux/lsm_hook_defs.h @@ -315,7 +315,7 @@ LSM_HOOK(int, 0, secctx_to_secid, const char *secdata, u32 seclen, u32 *secid) LSM_HOOK(void, LSM_RET_VOID, release_secctx, struct lsm_context *cp) LSM_HOOK(void, LSM_RET_VOID, inode_invalidate_secctx, struct inode *inode) LSM_HOOK(int, 0, inode_notifysecctx, struct inode *inode, void *ctx, u32 ctxlen) -LSM_HOOK(int, 0, inode_setsecctx, const struct path *path, void *ctx, u32 ctxlen) +LSM_HOOK(int, 0, path_setsecctx, const struct path *path, void *ctx, u32 ctxlen) LSM_HOOK(int, -EOPNOTSUPP, inode_getsecctx, struct inode *inode, struct lsm_context *cp) diff --git a/include/linux/security.h b/include/linux/security.h index 4f1c26c75093..c99a050595c5 100644 --- a/include/linux/security.h +++ b/include/linux/security.h @@ -584,7 +584,7 @@ int security_secctx_to_secid(const char *secdata, u32 seclen, u32 *secid); void security_release_secctx(struct lsm_context *cp); void security_inode_invalidate_secctx(struct inode *inode); int security_inode_notifysecctx(struct inode *inode, void *ctx, u32 ctxlen); -int security_inode_setsecctx(const struct path *path, void *ctx, u32 ctxlen); +int security_path_setsecctx(const struct path *path, void *ctx, u32 ctxlen); int security_inode_getsecctx(struct inode *inode, struct lsm_context *cp); int security_locked_down(enum lockdown_reason what); int lsm_fill_user_ctx(struct lsm_ctx __user *uctx, u32 *uctx_len, @@ -1626,7 +1626,7 @@ static inline int security_inode_notifysecctx(struct inode *inode, void *ctx, u3 { return -EOPNOTSUPP; } -static inline int security_inode_setsecctx(const struct path *path, void *ctx, u32 ctxlen) +static inline int security_path_setsecctx(const struct path *path, void *ctx, u32 ctxlen) { return -EOPNOTSUPP; } diff --git a/security/security.c b/security/security.c index f04a7bb311ea..7c17300989b6 100644 --- a/security/security.c +++ b/security/security.c @@ -4122,7 +4122,7 @@ int security_inode_notifysecctx(struct inode *inode, void *ctx, u32 ctxlen) EXPORT_SYMBOL(security_inode_notifysecctx); /** - * security_inode_setsecctx() - Change the security label of an inode + * security_path_setsecctx() - Change the security label of an inode * @path: inode * @ctx: secctx * @ctxlen: length of secctx @@ -4137,11 +4137,11 @@ EXPORT_SYMBOL(security_inode_notifysecctx); * * Return: Returns 0 on success, error on failure. */ -int security_inode_setsecctx(const struct path *path, void *ctx, u32 ctxlen) +int security_path_setsecctx(const struct path *path, void *ctx, u32 ctxlen) { - return call_int_hook(inode_setsecctx, path, ctx, ctxlen); + return call_int_hook(path_setsecctx, path, ctx, ctxlen); } -EXPORT_SYMBOL(security_inode_setsecctx); +EXPORT_SYMBOL(security_path_setsecctx); /** * security_inode_getsecctx() - Get the security label of an inode diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index ee0d6c12de37..81b7be7181e7 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -7176,7 +7176,7 @@ static int selinux_inode_notifysecctx(struct inode *inode, void *ctx, u32 ctxlen /* * called with inode->i_mutex locked */ -static int selinux_inode_setsecctx(const struct path *path, void *ctx, u32 ctxlen) +static int selinux_path_setsecctx(const struct path *path, void *ctx, u32 ctxlen) { return __vfs_setxattr_locked(path, XATTR_NAME_SELINUX, ctx, ctxlen, 0, NULL); @@ -7851,7 +7851,7 @@ static struct security_hook_list selinux_hooks[] __ro_after_init = { LSM_HOOK_INIT(release_secctx, selinux_release_secctx), LSM_HOOK_INIT(inode_invalidate_secctx, selinux_inode_invalidate_secctx), LSM_HOOK_INIT(inode_notifysecctx, selinux_inode_notifysecctx), - LSM_HOOK_INIT(inode_setsecctx, selinux_inode_setsecctx), + LSM_HOOK_INIT(path_setsecctx, selinux_path_setsecctx), LSM_HOOK_INIT(unix_stream_connect, selinux_socket_unix_stream_connect), LSM_HOOK_INIT(unix_may_send, selinux_socket_unix_may_send), diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c index 1a1e9f11939e..43f407ae007f 100644 --- a/security/smack/smack_lsm.c +++ b/security/smack/smack_lsm.c @@ -4978,7 +4978,7 @@ static int smack_inode_notifysecctx(struct inode *inode, void *ctx, u32 ctxlen) ctxlen, 0); } -static int smack_inode_setsecctx(const struct path *path, void *ctx, u32 ctxlen) +static int smack_path_setsecctx(const struct path *path, void *ctx, u32 ctxlen) { return __vfs_setxattr_locked(path, XATTR_NAME_SMACK, ctx, ctxlen, 0, NULL); @@ -5303,7 +5303,7 @@ static struct security_hook_list smack_hooks[] __ro_after_init = { LSM_HOOK_INIT(lsmprop_to_secctx, smack_lsmprop_to_secctx), LSM_HOOK_INIT(secctx_to_secid, smack_secctx_to_secid), LSM_HOOK_INIT(inode_notifysecctx, smack_inode_notifysecctx), - LSM_HOOK_INIT(inode_setsecctx, smack_inode_setsecctx), + LSM_HOOK_INIT(path_setsecctx, smack_path_setsecctx), LSM_HOOK_INIT(inode_getsecctx, smack_inode_getsecctx), LSM_HOOK_INIT(inode_copy_up, smack_inode_copy_up), LSM_HOOK_INIT(inode_copy_up_xattr, smack_inode_copy_up_xattr), -- 2.18.0.huawei.25
