Hi Eduardo, On Fri, 23 Oct 2026 10:49:46 +0200, Eduardo Mucelli Rezende Oliveira <[email protected]> wrote: > ftrace2bconf.sh reads each trigger line into "action active", keeping > only its first whitespace-separated word. For example, a histogram with > "if common_pid > 0" is exported without its filter. Reapplying that > configuration installs an unconditional histogram instead. > > Read the whole trigger line and remove only the trailing histogram state > marker. Quote the resulting action so that whitespace in a filter is > preserved in the exported configuration. > > Fixes: 2b86062a34a8 ("tools/bootconfig: Add a script to generates bootconfig > from ftrace") > Signed-off-by: Eduardo Mucelli Rezende Oliveira <[email protected]> > --- > Hi Masami, > > This is my third submission to the kernel. Feedback is welcome.
Please make your patches as a series of patches. You have sent the below patch on the similar topic. Those should be one series. https://lore.kernel.org/all/[email protected]/ Also, the \[\(foo\|bar\)\] seems gnu extension. Can you consider using more posix style like below? - sed 's/ \[\(active\|paused\)\]$//' | + sed -e 's/ \[active\]$//' -e 's/ \[paused\]$//' | Thank you, -- Masami Hiramatsu (Google) <[email protected]>
