Re: [PATCH v2 05/10] um: Determine sleep based on need_resched()

[Johannes Berg]

On Sun, 2025-08-10 at 13:51 +0800, Tiwei Bie wrote:
> 
>  void um_idle_sleep(void)
>  {
> -     if (time_travel_mode != TT_MODE_OFF)
> +     if (time_travel_mode != TT_MODE_OFF) {
>               time_travel_sleep();
> -     else
> +     } else {
> +             raw_local_irq_enable();
>               os_idle_sleep();
> +             raw_local_irq_disable();
> +     }

This seems wrong, with it, lockdep gets really unhappy, and if I remove
this change it seems to work OK?

I'll note that arch_cpu_idle() for x86 also doesn't change anything with
interrupts.

Was there something else that required this change that I'm missing?

johannes