From: George Wang <xuw2...@gmail.com>

now ovl only use O_RDONLY for lower and O_WRONLY for upper file. But if
the file size larger than MAX_NON_LFS(1UL << 31 -1), will suffer
-EOVERFLOW. We should add O_LARGEFILE flag to make it work. Following
script can reproduct it:

work
truncate: cannot open ‘work/sparse’ for writing: Value too large for
defined data type

Reported-by: Alkis Georgopoulos <alk...@gmail.com>
Signed-off-by: George Wang <xuw2...@gmail.com>
---
 fs/overlayfs/copy_up.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c
index 84d693d..e8ed965 100644
--- a/fs/overlayfs/copy_up.c
+++ b/fs/overlayfs/copy_up.c
@@ -81,11 +81,11 @@ static int ovl_copy_up_data(struct path *old, struct path 
*new, loff_t len)
        if (len == 0)
                return 0;
 
-       old_file = ovl_path_open(old, O_RDONLY);
+       old_file = ovl_path_open(old, O_RDONLY | O_LARGEFILE);
        if (IS_ERR(old_file))
                return PTR_ERR(old_file);
 
-       new_file = ovl_path_open(new, O_WRONLY);
+       new_file = ovl_path_open(new, O_WRONLY | O_LARGEFILE);
        if (IS_ERR(new_file)) {
                error = PTR_ERR(new_file);
                goto out_fput;
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to