> From: Pavel Machek <[EMAIL PROTECTED]>
> To: [EMAIL PROTECTED],
> Linux usb mailing list <[EMAIL PROTECTED]>
> Date: Tue, 12 Jun 2001 23:54:12 +0200
> Vojtech, you are maintainer; would you apply these cleanups?
I fail to see a point for most of them. Of course, Vojtech decides...
> struct acm_line {
> - __u32 speed;
> + u32 speed;
> } __attribute__ ((packed));
True, it's userland non-contamination, but they are perfectly
valid to use in kernel too.
> - acm->ctrlin & ACM_CTRL_FRAMING ? '+' : '-',
>acm->ctrlin & ACM_CTRL_PARITY ? '+' : '-',
> + acm->ctrlin & ACM_CTRL_FRAMING ? '+' : '-',
>acm->ctrlin & ACM_CTRL_PARITY ? '+' : '-',
ok, good
> - epctrl = ifcom->endpoint + 0;
> - epread = ifdata->endpoint + 0;
> + epctrl = ifcom->endpoint;
> + epread = ifdata->endpoint;
> epwrite = ifdata->endpoint + 1;
This was a nice way to say &v[0] without lispish bracketing.
-- Pete
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
http://lists.sourceforge.net/lists/listinfo/linux-usb-devel
