Jean Tourrilhes wrote:
>
> On Wed, Sep 19, 2001 at 03:42:18PM -0700, jt wrote:
> >
> > I did a quick read in the source to see if I could implement
> > ZERO_PACKET. Well, let's just say that it's not as simple as I
> > tought. TD are done multiple of 4096, which doesn't fit with the code
> > I see in usb-uhci which have TD multiple of 64 (so you just need to
> > add an empty TD at the end). There must be some black magic there.
>
> Well, I'm totally stupid, the TD size doesn't matter. Just add
> a TD at the end and don't worry, be happy.
> Patch attached. I don't know if the OHCI interface provide
> other way to do that more efficiently, but it works. Tested with my
> usual array of benchamrks and it's solid.
>
Hi Jean,
thanks for the patch, it looks good.
The only thing that could go wrong is when transfer_buffer_size == 0
then it will send two 0 size packets. So we have to check for
(!urb->transfer_buffer_size && (urb->transfer_buffer_size % pipe_mtu))
Thanks
Roman
Enjoy...
>
> Jean
>
> P.S. : Currently the irda-usb driver in the kernel can work only with
> usb-uhci, so if this patch could go in the kernel...
>
> ------------------------------------------------------------------------
>
> ir249_ohci_zero.diffName: ir249_ohci_zero.diff
> Type: Plain Text (text/plain)
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
