Greetings,
On 26-Sep-01 Jan Harkes wrote:
> On Wed, Sep 26, 2001 at 10:43:54AM -0400, Eloy A. Paris wrote:
>> I have been doing some tests to determine where the problems is. The
[snip]
> It hit me as well and I found the culprit, the crash happens in
> usb-uhci.c:process_iso, where the following code used to be 'safe'
>
> for (i = 0; p != &urb_priv->desc_list; i++) {
> ...
> list_del (p);
> p = p->next;
> delete_desc (s, desc);
> }
>
> However, some infidel sneaked the following change into 2.4.10, late in
> the testcycle, which is deadly. This patch needs to be reverted. If the
> behaviour is wanted all uses of list_del in the kernel need to be looked
> at very closely.
Personally, I say the above piece of code is faulty. Refering to a
pointer after you appearently deleted it, is just very bad programming
practice.
I�d say, fix the usb-uhci file, and do a quick run on all other instances
of list_del. I think most programmers got it right, or 2.4.10 kernels would
be coming down all over the planet.
- Nemosoft
-----------------------------------------------------------------------------
Try SorceryNet! One of the best IRC-networks around! irc.sorcery.net:9000
URL: never IRC: nemosoft IscaBBS (bbs.isca.uiowa.edu): Nemosoft
>> Never mind the daylight <<
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
