> > IMHO the returning of usb_submit_urb() should (and is, AFAICS) a clear
> > barrier indicating whether the completion handler will get called or not.
>
> Absolutely. Better say "The return code of usb_submit_urb()
> indicates if the callback was or will be called". If error
> is returned, no callback was or will be called for the URB.
> The past tense is for root hub and other imitation devices
> that deliver callbacks from inside of usb_submit_urb().
Yes. Please submit a patch against the 2.5.1-pre "usb.c" to make
it say that. Right now it only says (on that topic):
Successful submissions return 0; otherwise this routine
returns a negative error number.
That bit about completion only getting called when submission
was successful is worth adding. Write it so that the tense isn't
relevant ... some failure-during-submit scenarios could cause it
even if you're not talking about a root hub. (And I'm sure there
are some more doc clarifications worth having ... :)
- Dave
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
