On Wed, Dec 19, 2001 at 12:09:02AM -0800, David Brownell wrote:
> This patch adds "hcd" to usbcore, and lets you configure
> in the "ehci-hcd" driver. It includes Configure.help (so it
> won't be only an EXPERT option in CML2 :) and some
> basic Documentation/usb/ehci.txt background that should
> be useful to get folk quickly up to speed.
Thanks a lot for the documentation and Configure.help entry. I've added
this to my tree.
I also made the following minor patch to remove 2 compile time warnings
in the ehci driver, and a small Makefile fix that is needed for certain
.config situations for the hcd subdirectory.
Let me know if you have a problem with them.
thanks,
greg k-h
diff -Nru a/drivers/usb/Makefile b/drivers/usb/Makefile
--- a/drivers/usb/Makefile Wed Dec 19 09:42:08 2001
+++ b/drivers/usb/Makefile Wed Dec 19 09:42:08 2001
@@ -81,7 +81,7 @@
obj-$(CONFIG_USB_USBNET) += usbnet.o
# Object files in subdirectories
-mod-subdirs := serial
+mod-subdirs := serial hcd
subdir-$(CONFIG_EHCI_HCD) += hcd
subdir-$(CONFIG_USB_SERIAL) += serial
diff -Nru a/drivers/usb/hcd/ehci-dbg.c b/drivers/usb/hcd/ehci-dbg.c
--- a/drivers/usb/hcd/ehci-dbg.c Wed Dec 19 09:42:08 2001
+++ b/drivers/usb/hcd/ehci-dbg.c Wed Dec 19 09:42:08 2001
@@ -102,6 +102,7 @@
#ifdef DEBUG
+#if 0
static void dbg_qh (char *label, struct ehci_hcd *ehci, struct ehci_qh *qh)
{
dbg ("%s %p info1 %x info2 %x hw_curr %x qtd_next %x", label,
@@ -116,12 +117,15 @@
qh->hw_buf [4]);
}
}
+#endif
static const char *const fls_strings [] =
{ "1024", "512", "256", "??" };
#else
+#if 0
static inline void dbg_qh (char *label, struct ehci_hcd *ehci, struct ehci_qh *qh) {}
+#endif
#endif /* DEBUG */
/* functions have the "wrong" filename when they're output... */
diff -Nru a/drivers/usb/hcd/ehci-sched.c b/drivers/usb/hcd/ehci-sched.c
--- a/drivers/usb/hcd/ehci-sched.c Wed Dec 19 09:42:08 2001
+++ b/drivers/usb/hcd/ehci-sched.c Wed Dec 19 09:42:08 2001
@@ -381,7 +381,7 @@
vdbg ("qh %p usecs %d period %d starting frame %d.%d",
qh, qh->usecs, period, frame, uframe);
do {
- if (unlikely (ehci->pshadow [frame].ptr)) {
+ if (unlikely ((int)ehci->pshadow [frame].ptr)) {
// FIXME -- just link to the end, before any qh with a shorter period,
// AND handle it already being (implicitly) linked into this frame
BUG ();
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
