Hi, On Thu, Dec 20, 2001 at 04:44:38AM -0800, David Paschal wrote: > Hi, Greg. I would like to submit the following patch to printer.c for > inclusion into 2.5. It adds the ioctls I need for the HP OfficeJet Linux > driver project (http://hpoj.sourceforge.net) to dynamically switch > 7/1/[123] alternate settings and send an HP vendor-specific command > needed to support the photo-card readers on some HP PhotoSmart printers. > I have tested it heavily over the last several months on a variety of HP > printers, many of them multi-function peripherals. I also incorporated > some stylistic feedback from Pete Zaitcev (thanks, Pete!). > > The patch is against 2.4.13, but 2.5.1's printer.c is the same. If > possible, I would also like these changes incorporated into 2.4 and 2.2. > I added the necessary "#if"s so that the patched printer.c will work on > 2.2, 2.4, and 2.5. If you'd like, feel free to remove the version-specific > sections that are irrelevant to the version(s) you choose to accept.
The patch is word wrapped in places, and will not apply. Can you send it again (attachment is ok). > I didn't incorporate Oliver Neukum's and Pavel Machek's patches from two > weeks ago, because I don't know whether you incorporated them into your > trees. I waited for 2.5.1 to come out to see if any new changes showed > up since 2.4.13 that I should merge into my version, but there were none. No, I didn't add them, as the current printer driver maintainer did not comment on them. Same thing for this patch, you should also send it to him. :) In my opinion, I wouldn't add the version specific stuff as it's not needed, and the MODULE_* logic you added, is also not needed due to the locking in the file_operations structure. As for the future of 2.2 USB updates, if Alan Cox makes a new pre-release, I'll consider adding the patch to that tree. thanks, greg k-h _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
