On Wed, 19 Dec 2001, David Brownell wrote:

> But the drivers' ID tables are part of the module ...
> what's the locking being done to prevent rmmod
> during the usb_match_id() call?

On 2.5 it is protected, once the module subsystem patches are in, by
usb_match_id() not sleeping.
As this patch is intended for 2.5 it's ok this way.

On 2.4 the idea of unloading a module on SMP is slightly broken anyway.
In 2.4 you must hold the big kernel lock whenever you access the drivers
in this way. The module usage count must still be incremented before
you sleep. The kernel thread holds BKL, as does insmod. I think it's ok,
but I haven't gone through everything to check.

Greg and I have discussed a similar patch for 2.4 some time past and Greg
rejected it as too intrusive. I think he was right.
Thus this patch is for 2.5 and adds minimal infrastructure only.

        Regards
                Oliver



_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to