On Sat, Jan 12, 2002 at 10:26:53AM +0100, Peter Osterlund wrote:
> Matthew Dharm <[EMAIL PROTECTED]> writes:
> 
> > That fix breaks all sorts of other devices.
> > 
> > This is an icky problem, because the issue is not the dongle, but what's
> > on the other side of the dongle.
> > 
> > You can't have usb-storage do any mode translation, because it screws up
> > other devices (Traveller CD-RW, OnStream Tape, etc.)
> 
> The only difference between the protocols seems to be translation of
> MODE_SENSE/SELECT and READ/WRITE from the short to the long versions.
> Is the problem that there are devices on the other side of a Freecom
> cable that only support the short versions?

Yes.

> > Hrm...
> > 
> > sr.c doesn't have anything to do with writing... that's all done in
> > userspace.  Are you using cdrecord?
> 
> It does if you apply the packet writing patch. (Which will probably be
> included in the standard kernel in 2.5.) See:
> 
>         http://www.kernel.org/pub/linux/kernel/people/axboe/packet/
>         http://w1.894.telia.com/~u89404340/patches/packet/

Then this should be updated to use the 10-byte commands.

> Maybe the code in sr.c could be changed to use MODE_SENSE_10 instead
> of MODE_SENSE, or at least try the 10-byte version if the 6-byte
> version fails. But that seems more like a workaround. Either
> usb-storage needs to handle MODE_SENSE(6) or it doesn't. Currently,
> the code apparently tries to handle it, but fails in my particular
> case.

The problem is that the ATAPI devices attached to the bridge are not all
the same.  The OnStream drive does not handle 10-byte.  The Traveller does.
I guess your device does also.

Honestly, why sr.c still uses the 6-byte commands is beyond me.  I think
the proper behavior should be to use the 10-byte, and fallback on the
6-byte if necessary.  Or check the SCSI version number first.

Matt

-- 
Matthew Dharm                              Home: [EMAIL PROTECTED] 
Maintainer, Linux USB Mass Storage Driver

M:  No, Windows doesn't have any nag screens.
C:  Then what are those blue and white screens I get every day?
                                        -- Mike and Cobb
User Friendly, 1/4/1999

Attachment: msg03908/pgp00000.pgp
Description: PGP signature

Reply via email to