On Tue, Jan 22, 2002 at 02:17:42PM +0100, Georg Acher wrote: > Hi, > this patch for usb-uhci fixes the the following problems: > > - one shot interrupts work now, there was a wrong data toggle... > - correct timeout check with time_after-macros > - memory leak in synchronous unlinking of interrupt URBs > - uhci_pci_remove was declared __devexit > - CPU-speed dependent delay in start_hc() > > It should apply cleanly to 2.4.17 and also (maybe with a offset) to 2.5.2.
Looks good, I added it to my 2.4 and 2.5 trees. I also added the patch below to the 2.4 version, as uhci_pci_remove is not a __devexit function anymore. Let me know if this is not ok. thanks, greg k-h diff -Nru a/drivers/usb/usb-uhci.c b/drivers/usb/usb-uhci.c --- a/drivers/usb/usb-uhci.c Tue Jan 22 08:53:21 2002 +++ b/drivers/usb/usb-uhci.c Tue Jan 22 08:53:21 2002 @@ -3077,7 +3077,7 @@ id_table: &uhci_pci_ids [0], probe: uhci_pci_probe, - remove: __devexit_p(uhci_pci_remove), + remove: uhci_pci_remove, #ifdef CONFIG_PM suspend: uhci_pci_suspend, _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel