> > In fact as it stands, I think this area needs some work because the > > device probe loop during enumeration isn't actually telling devices > > what altsetting to use, if it's anything other than the default after > > setting the configuration... > > IMHO, if a device comes with multiple AS and the driver wants to use an > AS other than the default one, it is the driver's job to manage the AS.
That would mean the usb.c find_interface_driver() code should change so it doesn't touch the altsetting. That makes sense to me, but that's the kind of work I was talking about. (Today it modifies the host's record of altsetting, but doesn't tell devices about that ...) Drivers might depend on that current strange behavior. > I would even go one step further: > I personally don't see any good reason, why usbcore should _ever_ call > usb_set_interface(). Again, managing AS and/or resetting interfaces is > IMHO not something that should be done by the usbcore. I guess I don't see any problem calling it in usb_reset_device() in the case that it's already been successfully called to change the altsetting. On the other hand it's a LOT cleaner to have the simple policy you identified: drivers always handle altsetting. - Dave _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
