On Thu, Feb 14, 2002 at 02:18:54AM +0100, Martin Diehl wrote: > > the attached patch below addresses both problems: > > * usb_hub_port_debounce() provides the required debounce delay including > the "restart delay when spurious disconnect detected" behaviour > described in 7.1.7.1. However, I've used a minimum delay of 200ms > (instead TATTDB > 100ms) as this turned out to be needed to solve > the "not accepting new address" problem relyably for my usb-irda dongle. > I've kept the additional 400ms delay for low speed device as I wasn't > able to test whether this issue is still there. > Did some testing with both the usb-irda and the EZ-USB FX dev. board, > where the latter one turned out to be a pretty good trigger for connect/ > disconnect races on hub-port, when one starts repeatedly pressing the > reset/disconnect button - Looks good for me now!
Looks good. But why aren't you restarting the timeout when you detect a disconnect? Right now it looks if you see a disconnect for 30ms, then you error out. > * usb_hub_port_status() was introduced to wrap the calls for > usb_get_port_status and uses a kmalloced temporary buffer instead > of exposing stack locations to PCI-DMA. Had it included during the > debounce tests and it work as expected for me. > > Patch created and tested with 2.4.18-pre9. Again, I'd like to try this out in 2.5.x for a while before adding it to 2.4. thanks, greg k-h _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
