Re: [linux-usb-devel] 2.5.6-pre2 -- Immediate lockup when hid driver is loaded!

[Vojtech Pavlik]

On Fri, Mar 01, 2002 at 05:01:50PM -0800, Miles Lane wrote:
> I have a USB Optical MS IntelliMouse and MS USB Internet Keyboard Pro.
> 
> Any hints about how I might gather useful debugging information
> would be most welcome.  When the lockup occurs, there is no
> OOPS, but the NumLock and CapsLock lights don't toggle.  
> The SysRq keys don't work either, AFAICT.

Does this help?

-- 
Vojtech Pavlik
SuSE Labs

diff -u -r1.45 -r1.46
--- hid-core.c  21 Feb 2002 09:27:10 -0000      1.45
+++ hid-core.c  27 Feb 2002 22:26:58 -0000      1.46
@@ -1,5 +1,5 @@
 /*
- * $Id: hid-core.c,v 1.45 2002/02/21 09:27:10 vojtech Exp $
+ * $Id: hid-core.c,v 1.46 2002/02/27 22:26:58 jdeneux Exp $
  *
  *  Copyright (c) 1999 Andreas Gal
  *  Copyright (c) 2000-2001 Vojtech Pavlik
@@ -1047,6 +1048,7 @@
 
        if (hid->outhead != hid->outtail) {
                hid_submit_out(hid);
+               spin_unlock_irqrestore(&hid->outlock, flags);
                return;
        }
 
@@ -1078,6 +1080,7 @@
 
        if (hid->ctrlhead != hid->ctrltail) {
                hid_submit_ctrl(hid);
+               spin_unlock_irqrestore(&hid->ctrllock, flags);
                return;
        }