On Wed, Mar 13, 2002 at 03:12:23PM -0800, Greg KH wrote:
> [EMAIL PROTECTED], 2002-03-13 14:35:53-08:00, [EMAIL PROTECTED]
> USB ipaq driver
>
> Fixed a panic caused by the line discipline echoing characters. It
> also fixes a problem where the echoing messes up ppp chat.
>
> drivers/usb/serial/ipaq.c | 12 ++++++++++++
> 1 files changed, 12 insertions(+)
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.420 -> 1.421
# drivers/usb/serial/ipaq.c 1.3 -> 1.4
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 02/03/13 [EMAIL PROTECTED] 1.421
# USB ipaq driver
#
# Fixed a panic caused by the line discipline echoing characters. It
# also fixes a problem where the echoing messes up ppp chat.
# --------------------------------------------
#
diff -Nru a/drivers/usb/serial/ipaq.c b/drivers/usb/serial/ipaq.c
--- a/drivers/usb/serial/ipaq.c Wed Mar 13 15:02:37 2002
+++ b/drivers/usb/serial/ipaq.c Wed Mar 13 15:02:37 2002
@@ -9,6 +9,16 @@
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
+ * (8/3/2002) ganesh
+ * The ipaq sometimes emits a '\0' before the CLIENT string. At this
+ * point of time, the ppp ldisc is not yet attached to the tty, so
+ * n_tty echoes "^ " to the ipaq, which messes up the chat. In 2.5.6-pre2
+ * this causes a panic because echo_char() tries to sleep in interrupt
+ * context.
+ * The fix is to tell the upper layers that this is a raw device so that
+ * echoing is suppressed. Thanks to Lyle Lindholm for a detailed bug
+ * report.
+ *
* (25/2/2002) ganesh
* Added support for the HP Jornada 548 and 568. Completely untested.
* Thanks to info from Heath Robinson and Arieh Davidoff.
@@ -148,6 +158,8 @@
*/
port->tty->low_latency = 1;
+ port->tty->raw = 1;
+ port->tty->real_raw = 1;
/*
* Lose the small buffers usbserial provides. Make larger ones.
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
