On Fri, Mar 22, 2002 at 11:17:19PM +0530, V Ganesh wrote: > hi greg, > there's a problem with your recent change to move open count > accounting to usbserial.c. consider the case when the cable is yanked, causing > a disconnect. usbserial will clean up very thoroughly so that no further > close/write etc will get in. some drivers (at least visor and > ipaq) now have empty shutdown functions. no further close will get in > beyond the first couple of lines of serial_close(). this means that the > module count is not decremented properly.
Yes, this problem was present even before I made this change. It can also happen in 2.4, as a lot of Clie users can attest to :) This area of the driver needs to be fixed, and is on my list of things todo. The move of open_count was part of this work. > ipaq also leaks memory now, since the private data structures which > were previously freed in shutdown by calls to close() no longer happen. > I'll submit a patch for this along with some other cleanups soon. Sorry I missed that logic in the ipaq driver, most of the other usb-serial drivers do their local cleanup in the disconnect function. thanks, greg k-h _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
