I'm working on a patch for hpusbscsi.c to update the debugging statements and
allow them to be #ifdef (rather than hardcoded to "on" as they are now). I
noted that usb.h has the dbg macro "#ifdef DEBUG", why isn't this
"#ifdef CONFIG_USB_DEBUG"? When configing my kernel - I select
CONFIG_USB_DEBUG to expect to see these debug statements. I can see the
argument that "DEBUG" is more generic so when recompiling individual modules
you may just choose DEBUG. I don't know what the right answer is. Opinions?
i.e.
--- /usr/include/linux/usb.h Sun Mar 24 11:01:07 2002
+++ /usr/include/linux/usb.new.h Fri Apr 19 23:00:17 2002
@@ -984,7 +984,7 @@
void usb_show_device(struct usb_device *);
void usb_show_string(struct usb_device *dev, char *id, int index);
-#ifdef DEBUG
+#ifdef CONFIG_USB_DEBUG
#define dbg(format, arg...) printk(KERN_DEBUG __FILE__ ": " format "\n" , ##
arg)
#else
#define dbg(format, arg...) do {} while (0)
-----
Timothy Jedlicka, [EMAIL PROTECTED], 1-630-713-4436, AOL-IM=bonzowork
Network Entomologist, Lucent Technologies, Testers For Hire
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
