On Sun, May 12, 2002 at 03:28:49PM -0400, Johannes Erdfelt wrote:
>
> I've tested with uhci and usb-ohci with no adverse effects.
Looks good. I have a follow-on patch to yours that I'll send in a bit
after more testing. But I did have one question:
> diff -ur linux-2.5.15.orig/drivers/usb/host/usb-uhci.c
>linux-2.5.15/drivers/usb/host/usb-uhci.c
> --- linux-2.5.15.orig/drivers/usb/host/usb-uhci.c Thu May 9 15:24:15 2002
> +++ linux-2.5.15/drivers/usb/host/usb-uhci.c Sun May 12 09:08:34 2002
> @@ -2221,14 +2221,6 @@
> return -EPROTO;
> }
>
> -/*
> - * Only the USB core should call uhci_alloc_dev and uhci_free_dev
> - */
> -_static int uhci_alloc_dev (struct usb_device *usb_dev)
> -{
> - return 0;
> -}
> -
> _static void uhci_unlink_urbs(uhci_t *s, struct usb_device *usb_dev, int remove_all)
> {
> unsigned long flags;
> @@ -2258,20 +2250,6 @@
> spin_unlock_irqrestore (&s->urb_list_lock, flags);
> }
>
> -_static int uhci_free_dev (struct usb_device *usb_dev)
> -{
> - uhci_t *s;
> -
> -
> - if(!usb_dev || !usb_dev->bus || !usb_dev->bus->hcpriv)
> - return -EINVAL;
> -
> - s=(uhci_t*) usb_dev->bus->hcpriv;
> - uhci_unlink_urbs(s, usb_dev, 0);
> -
> - return 0;
> -}
> -
> /*
> * uhci_get_current_frame_number()
> *
> @@ -2284,8 +2262,6 @@
>
> struct usb_operations uhci_device_operations =
> {
> - allocate: uhci_alloc_dev,
> - deallocate: uhci_free_dev,
> get_frame_number: uhci_get_current_frame_number,
> submit_urb: uhci_submit_urb,
> unlink_urb: uhci_unlink_urb,
Don't we need to keep uhci_free_dev() in the usb-uhci.c file? Isn't
uhci_unlink_urbs() needed to be called when we free up the device? Or
does that also happen elsewhere (i.e. on disconnect)?
thanks,
greg k-h
_______________________________________________________________
Have big pipes? SourceForge.net is looking for download mirrors. We supply
the hardware. You get the recognition. Email Us: [EMAIL PROTECTED]
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
