On Sun, May 12, 2002 at 03:21:24PM +0200, Manfred Spraul wrote: > > I found several SMP and UP locking errors in usb-storage, attached is a > patch: > > Changes: > * srb->result is a bitfield, several << 1 were missing. > * further sg[].address conversions. I've added a macro to facilitate > code sharing between 2.4 and 2.5. What are your plans for that? > * add scsi_lock calls around midlayer calls, release the lock before > calling usb functions that might sleep. > * replace the queue semaphore with a queue spinlocks, queuecommand is > called from bh context. > > I've tried to send the patch to the usb-storage list, but it that list > is a member-only list. > > I've tested the patch with my SaroTech usb disk (bulk device).
Thanks for doing this, I've been hearing reports that the locking was not quite correct in the usb-storage driver for quite some time. I already submitted the page_address() change to Linus, but the rest of the patch should apply cleanly. Matt, what do you think about the changes? thanks, greg k-h _______________________________________________________________ Have big pipes? SourceForge.net is looking for download mirrors. We supply the hardware. You get the recognition. Email Us: [EMAIL PROTECTED] _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
