On Mon, May 13, 2002 at 12:19:48PM -0400, Johannes Erdfelt wrote: > > So what you wrote above "Now when the last person calls > usb_put_dev()..." was also describing the changes relative to David's > original method of doing reference counting and not to my patch?
I think so... it was late, I don't remember what I was referring to :) But this is the way the code now works, with both of our patches, which is the important thing. > I was talking about something else, specifically the extra cleanups some > HCD's had. > > Take for instance usb-uhci.c. Georg even responded saying he didn't feel > comfortable removing that. > > However, I've proven that there's no possible way for the disconnect > callback to be made if reference counting is being used correctly. In > that case, the code is completely superfluous. > > I made the same mistake originally, but I removed it from uhci.c when I > realized that it's an impossible condition. Ah, I understand now. Thanks for clearing this up. So can the allocate() and deallocate() calls for usb-ohci.c and hcd.c be removed also? If so, can't they be dropped from the core all together? thanks, greg k-h _______________________________________________________________ Have big pipes? SourceForge.net is looking for download mirrors. We supply the hardware. You get the recognition. Email Us: [EMAIL PROTECTED] _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
