> You're targeting your code for the wrong system. You should be coding > assuming a working system. You shouldn't be assuming a buggy system.
You're targetting your comments at the wrong person ... :) That summary _does_ assume a working system. Even the comments about TDs (or for EHCI, QTDs) ... those need to be cleaned up not just for buggy device drivers, but also for when the host controller halted due to error, and _all_ the HCD state needs to be cleaned up. It's just good design fallout win that when such device driver bugs exist, they're handled cleanly (no oops). > When you remove all of that extra code, it appears to reduce down to a > single pci_pool_free call. Is that correct? No extra code ... that's wrong. As I said, it's possible that a QH may still be linked to the hardware after its URBs are unlinked. (Or for OHCI, an ED.) We know that (modulo bugs) all URBs will be unlinked when that code is called. We can't know that all QHs will be, since that involves a hardware handshake that for various reasons may not have been completed -- or even started -- by then. - Dave _______________________________________________________________ Have big pipes? SourceForge.net is looking for download mirrors. We supply the hardware. You get the recognition. Email Us: [EMAIL PROTECTED] _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
