On Wed, May 15, 2002 at 01:32:35PM -0700, David Brownell wrote:
> > After maturing for more than a month, I decided that it's enough...
> > So here's the patch for the HCD-version of usb-uhci, I called it
> > usb-uhci-hcd. For me, the usual devices work (TM).
>
> Cool! I built it, saw a smaller object size (by about a page),
> and glanced quickly at the code. I'll try using it later.
Good luck ;-)
> That defibrillator seems useful, and I like the name ... :)
I have seen too much ER... If I can find out why VIA-UHCI has no problems
with babble when using the Windows driver, it would be not that important...
The watchdog still needs a little improvement. Currently it uses one of the
128ms-interrupt TDs to generate the heartbeat-interrupt, once a second would
be enough.
BTW: The watchdog itself sits in uhci_hub_status_data(), thus independent of
the UHCI timing and only sets a restart flag. That flag is checked in the
next submit_urb and if not in_interrupt(), the whole descriptor skeleton
(and all pending urbs) are removed and a new skeleton is initialized. I
simply don't trust any remaining HW-related structures after such a
failure, it still possible that the HCD itself made some
spaghetti-descriptors...
> > More comments and the separation into multiple files (I've taken ohci-hcd as
> > an example) should make the code more concise...
>
> It can become a bit slimmer still, though. Do you really need
> both the "dbg.c" and "debug.h"? It's not leveraging all the
Hm, usb-uhci-debug.h belongs to the old usb-uhci. usb-uhci-hcd only
needs the usb-uhci-dbg.c. They are very similar ;-)
> request cleanup done in the layer above -- like forcing periodic
> transfer intervals to be a power of two. And the urb->next
> stuff should go too ... if that remains at all, it belongs in the
> hcd framework code, not inside the individual HCDs.
Oops, I thought I had it removed, wishful thinking... One point more on the
todo-list...
> It shouldn't force CONFIG_USB_DEBUG on if it's already
> set, but it's just a simple tweak to get rid of that warning.
That's a leftover from my debugging sessions...
--
Georg Acher, [EMAIL PROTECTED]
http://www.in.tum.de/~acher/
"Oh no, not again !" The bowl of petunias
_______________________________________________________________
Have big pipes? SourceForge.net is looking for download mirrors. We supply
the hardware. You get the recognition. Email Us: [EMAIL PROTECTED]
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
