Sure, I'll send it off to the v4l folks, but n.b. the (second) patch is correct. The other function (et al) are wrapped in a larger scoped #ifdef/#endif.
-ch > -----Original Message----- > From: Greg KH [mailto:[EMAIL PROTECTED]] > Sent: Tuesday, June 11, 2002 3:34 PM > To: Christopher Hoover > Cc: [EMAIL PROTECTED] > Subject: Re: [linux-usb-devel] [PATCH] videodev_proc_destroy > undefined (mkii) > > > On Tue, Jun 11, 2002 at 03:26:34PM -0700, Christopher Hoover wrote: > > # This is a BitKeeper generated patch for the following project: # > > Project Name: greg k-h's linux 2.5 USB kernel tree # This > patch format > > is intended for GNU patch command version 2.5 or higher. # > This patch > > includes the following deltas: > > # ChangeSet 1.611 -> 1.613 > > # drivers/media/video/videodev.c 1.7 -> 1.9 > > # > > # The following is the BitKeeper ChangeSet Log > > # -------------------------------------------- > > # 02/06/11 [EMAIL PROTECTED] 1.612 > > # videodev_proc_destory is needed when built-in to kernel too # > > -------------------------------------------- > > # 02/06/11 [EMAIL PROTECTED] 1.613 > > # This pair of #if/#endif are redundant. > > # -------------------------------------------- > > # > > diff -Nru a/drivers/media/video/videodev.c > b/drivers/media/video/videodev.c > > --- a/drivers/media/video/videodev.c Tue Jun 11 15:26:34 2002 > > +++ b/drivers/media/video/videodev.c Tue Jun 11 15:26:34 2002 > > @@ -288,8 +288,6 @@ > > video_dev_proc_entry->owner = THIS_MODULE; > > } > > > > -#ifdef MODULE > > -#if defined(CONFIG_PROC_FS) && > defined(CONFIG_VIDEO_PROC_FS) static > > void videodev_proc_destroy(void) { > > if (video_dev_proc_entry != NULL) > > @@ -298,8 +296,6 @@ > > if (video_proc_entry != NULL) > > remove_proc_entry("video", &proc_root); > > } > > -#endif > > -#endif > > > > static void videodev_proc_create_dev (struct video_device > *vfd, char > > *name) { > > > Like Tom said, the CONFIG_PROC_FS check should probably be > moved up a function, not just removed. And try sending this > to the author/maintainer of the v4l subsystem, us USB people > can't help much here :) > > thanks, > > greg k-h > _______________________________________________________________ Multimillion Dollar Computer Inventory Live Webcast Auctions Thru Aug. 2002 - http://www.cowanalexander.com/calendar _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
