Hi,

the lock is not held long enough.

        Regards
                Oliver


You can import this changeset into BK by piping this whole message to:
'| bk receive [path to repository]' or apply the patch as usual.

===================================================================


[EMAIL PROTECTED], 2002-07-11 17:39:58+02:00, [EMAIL PROTECTED]
  - fix usb open/module unload race




diff -Nru a/drivers/usb/core/file.c b/drivers/usb/core/file.c
--- a/drivers/usb/core/file.c   Thu Jul 11 17:40:34 2002
+++ b/drivers/usb/core/file.c   Thu Jul 11 17:40:34 2002
@@ -44,10 +44,13 @@
 
        spin_lock (&minor_lock);
        c = usb_minors[minor];
-       spin_unlock (&minor_lock);
 
-       if (!c || !(new_fops = fops_get(c)))
+       if (!c || !(new_fops = fops_get(c))) {
+               spin_unlock(&minor_lock);
                return err;
+       }
+       spin_unlock(&minor_lock);
+
        old_fops = file->f_op;
        file->f_op = new_fops;
        /* Curiouser and curiouser... NULL ->open() as "no device" ? */

===================================================================


This BitKeeper patch contains the following changesets:
1.667
## Wrapped with gzip_uu ##


begin 664 bkpatch2894
M'XL(`/*F+3T``ZV4;V_3,!#&7\>?XJ9)T&JDL9TX:8J*!AN""22JHKU#JA+G
MTD3YX\I)UB'"=\=IH1,2*Z(LBDZ.SW=^_.27G,-M@WIFJ3*_0TW.X;UJ6O.(
MM:IQDJD*R[SN[B=*KTURJ91).L.TLZ]PXL)N-6+C;+D@9LDB:F4&)M/,+#9Q
M#S/MUPW.K.7;=[<?7R\)F<_A*HOJ-7[&%N9S$A>728?EI-`JRH;=^D.ZYY0R
MQKB@KO"9Z/G4=;V>^31.S##A09C&?DCV>B[_I/SW7IP&C)IRC]->^,+UR#6P
MB>\'0+E#`X<Q8,',#6=B>D'YC%(XTAHN&-B4O('_/\`5D6!#FM]#U\2@-E@[
ME4JZ$J&K2Q4EH".)Y`.((.0A63SX1^Q_O`BA$26O8*UQ?;D7+%75)WHX9N.8
M[1VI-#II7N)$_O2,^I2YQK6>^E,WZ%W?$TS&0>0S'B:"'3/I+YV--\(-Q;0W
M%GG^CHU'"@92GE+T2<U$3\,I%3MJ^&G,"+#Y$S+39@BED@547=-"C)!AF1AJ
MVKR$*&U10ZHVS6J-[0O`LL&A0./S!J)?3.V=_P2VWNYNP\CBL9=P`F[77@#,
MQ-#$&Q,YL?(41F<2^A[.1C5N5X-"F!^$CN1X/(9OQ+*:35ZOAB]`%J-G55XK
HO1K&XY?D1E!PB?6='%GSY>&?)#.41=-5<TQ0B*G+R`_"56[#_00`````
`
end



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
PC Mods, Computing goodies, cases & more
http://thinkgeek.com/sf
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to