On Wed, 9 Oct 2002, Adam J. Richter wrote: | Linux-2.5.41 now prints a warning with a strack trace when a | routine that could block, such as down(), is called from an interrupt | context. usb_hub_events did this, with a comment claiming that the | down() call would never block. The following patch replaces the | down call with "if(trylock_down(...)) BUG();", which eliminates the | warning, causes the code to correctly generate a BUG() if the claim | in the comment is false, and might even be a couple of cycles faster. | | I'm unsure what the preferred approval process is for changes | to drivers/usb/core/hub.c, but I see Brad Hards has the most recent | copyright notice on hub.c, so I'm emailing this to Brad and | linux-usb-devel. I'd appreciate it someone would let me know either | that they're integrating this patch for submission to Linus or that | there is something else I should do to get this patch in the pipeline.
JE (Johannes Erdfelt) is still the hub maintainer. >From MAINTAINERS file: USB HUB P: Johannes Erdfelt M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] L: [EMAIL PROTECTED] S: Maintained -- ~Randy "In general, avoiding problems is better than solving them." -- from "#ifdef Considered Harmful", Spencer & Collyer, USENIX 1992. ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
