(l-k removed because, well, nobody there seemed to care)
On Fri, 25 Oct 2002, Greg KH wrote:
> On Fri, Oct 25, 2002 at 02:04:25AM -0500, Josh Myer wrote:
> Please use tabs instead of spaces. Documentation/CodingStyle has these
> rules if you haven't read it yet.
>
Done.
> Please use usb_fill_int_urb() for all new code, and don't use the
> "old-style" macros.
>
usb_fill_int_urb() bit done. Would anyone like to update wacom.c to
reflect this, or are there any objections to me doing so and posting?
I'm a bit ignorant here, sorry. Are you referring to simply the
FILL_INT_URB(), or to the BIT() and friends as well, in the _probe
function?
Sorry if i'm asking a dumb question -- i'm new to USB (give me a parallel
port or an ISA slot any day =)
> C99 style initializers are a good idea:
> Other than those minor things, looks good.
>
> thanks,
>
No, thank you for the feedback--it's really appreciated. I'm currently
staring at some details before my next posting, and hoping to get 2.5
changes in as well.
--
/jbm, but you can call me Josh. Really, you can!
this signature brought to you by the phrase,
"this signature brought to you by the phrase,
'...' and contributions by viewers like you"
7958 1C1C 306A CDF8 4468 3EDE 1F93 F49D 5FA1 49C4
-------------------------------------------------------
This sf.net email is sponsored by: Influence the future
of Java(TM) technology. Join the Java Community
Process(SM) (JCP(SM)) program now.
http://ads.sourceforge.net/cgi-bin/redirect.pl?sunm0004en
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
