On Sun, 2002-10-27 at 09:11, Duncan Sands wrote: > > > + /* Wait for the current transaction to finish */ > > > + status = inw(io_addr + USBSTS); > > > + while (!(status & USBSTS_HCH)) > > > + status = inw(io_addr + USBSTS); > > > + > > > outw(USBCMD_EGSM, io_addr + USBCMD); > > > > These loops need timeouts. Suppose I unplugged the USB controller on my > > cardbus at that moment ? > > Then the system will go down! A devil tempts me to point out that it would have > gone down before this patch as well - look in wakeup_hc a few lines below... > But you are right of course - I will put in a timeout and, sigh, I will audit uhci.c > and put in timeouts everywhere else as well.
The problem is all over the place. I've been going over some scsi drivers and realised the scale of the mess, thats why I noticed it in your patch 8) ------------------------------------------------------- This SF.net email is sponsored by: ApacheCon, November 18-21 in Las Vegas (supported by COMDEX), the only Apache event to be fully supported by the ASF. http://www.apachecon.com _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
