Duncan Sands wrote:
@@ -381,10 +385,10 @@ return -EINVAL; err = -EINVAL; dev = ps->dev; + iface = &dev->actconfig->interface[intf]; down(&dev->serialize); if (dev && test_and_clear_bit(intf, &ps->ifclaimed)) { - iface = &dev->actconfig->interface[intf]; - usb_driver_release_interface(&usbdevfs_driver, iface); + device_unbind (&iface->dev); err = 0; } up(&dev->serialize);Notice the test for dev being NULL after dev has been used? (This is not really a comment on your patch: the problem was already there before).
Actually just sloppiness, not a bug -- all code paths test for ps->dev before they call releaseintf, that test is not needed. And for that matter "iface = ..." didn't need to move, I'm not sure how that got in. - Dave ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
