Hi!
> I've been experimenting with the Zaurus support and have come across two
> problems.
> The first (patch against 2.4.20 included) is that the tx_fixup adds 6 bytes
> for the CRC and padding, but the logic to pad the packet if it is a multiple
> of the block size in usbnet_start_xmit is working off the old buffer size.
> This meant an occasional packet having an extra byte, which then failed the
> CRC on the Z.
Nice catch!
> The second is that if the Z sends packets of length equal to the MTU size, the
> receive buffer allocated in rx_submit doesn't include room for the 4 byte
> CRC. I've hacked a +4 onto the buffer size, and that works fine for me, but
> that's not a public fix. Is this the right place in the code to fix
> this?
Can you at least post a hack? I suspected something like that but
could not find it.
> @@ -1953,6 +1953,9 @@
> }
> }
>
> + //As tx_fixup can change skb length, fetch it after fixup
C++ -style comments should not be used in kernel code.
> + length=skb->len;
> +
> if (!(urb = ALLOC_URB (0, GFP_ATOMIC))) {
> dbg ("no urb");
> goto drop;
Pavel
--
Casualities in World Trade Center: ~3k dead inside the building,
cryptography in U.S.A. and free speech in Czech Republic.
-------------------------------------------------------
This sf.net email is sponsored by:
With Great Power, Comes Great Responsibility
Learn to use your power at OSDN's High Performance Computing Channel
http://hpc.devchannel.org/
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
