ChangeSet 1.889.379.4, 2003/03/21 17:00:25-08:00, [EMAIL PROTECTED]
[PATCH] USB: potential dereference of user pointer errors in kobil_sct.c
drivers/usb/serial/kobil_sct.c | 17 ++---------------
1 files changed, 2 insertions(+), 15 deletions(-)
diff -Nru a/drivers/usb/serial/kobil_sct.c b/drivers/usb/serial/kobil_sct.c
--- a/drivers/usb/serial/kobil_sct.c Tue Mar 25 16:47:20 2003
+++ b/drivers/usb/serial/kobil_sct.c Tue Mar 25 16:47:20 2003
@@ -406,8 +406,6 @@
int result = 0;
int todo = 0;
struct kobil_private * priv;
- int i;
- char *data;
if (count == 0) {
dbg("%s - port %d write request of 0 bytes", __FUNCTION__,
port->number);
@@ -421,19 +419,6 @@
return -ENOMEM;
}
- // BEGIN DEBUG
- data = (unsigned char *) kmalloc((3 * count + 10) * sizeof(char), GFP_KERNEL);
- if (! data) {
- return (-1);
- }
- memset(data, 0, (3 * count + 10));
- for (i = 0; i < count; i++) {
- sprintf(data +3*i, "%02X ", buf[i]);
- }
- dbg(" %d --> %s", port->number, data );
- kfree(data);
- // END DEBUG
-
// Copy data to buffer
if (from_user) {
if (copy_from_user(priv->buf + priv->filled, buf, count)) {
@@ -442,6 +427,8 @@
} else {
memcpy (priv->buf + priv->filled, buf, count);
}
+
+ usb_serial_debug_data (__FILE__, __FUNCTION__, count, priv->buf +
priv->filled);
priv->filled = priv->filled + count;
-------------------------------------------------------
This SF.net email is sponsored by:
The Definitive IT and Networking Event. Be There!
NetWorld+Interop Las Vegas 2003 -- Register today!
http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
