On Mon, 2 Jun 2003, David Brownell wrote:

> Alan Stern wrote:
> 
> > Some significant changes to the error recovery code were just accepted 
> > into Greg K-H's kernel tree.  They will probably show up in the main 
> > distribution in 2.5.71, or you can get them right now by BitKeeper from 
> > bk://linuxusb.bkbits.net/usb-2.5.  With these changes, the errors you see 
> > shouldn't stop things in dead in their tracks (although they might cause a 
> > 10-second delay).  Of course, that's just in theory -- who knows what will 
> > happen when you actually try it!
> > 
> > Of course, persisting in the face of errors is all very nice, but it would 
> > be better to eliminate the errors in the first place.
> 
> Yes, I noticed those patches ... their effect should be interesting.
> 
> I hope you're not saying it's OK for fault recovery code to oops,
> since I'll strongly disagree.  **Faults happen** as do true errors
> (hardware and software) ... fault recovery is essential.  I know
> that stuff is hard to debug.

Nothing I wrote was intended even to give the impression that an oops is 
okay.  All I said was that the error recovery might be better now than it 
was, and that it would be good to fix the original errors (assuming they 
have a systematic cause).

> At this point, it's not clear to me that there's any real error
> happening except in the recovery code.  I'm not saying there
> isn't a second problem -- only that there's only evidence of that
> one problem (in fault recovery) just now.  And having the fault
> recovery work right will certainly help turn up proof if there
> really is some other problem.

Yes, maybe the original error is just a random fault, and the
usb_bulk/control_msg timeouts are the only real problem.  However, the new
changes mean that usb_control_msg() is no longer called by usb-storage.  
Maybe something else will malfunction instead.  Also, Mitch's comments 
indicate to me that this is likely to be something more than a random 
fault.

> > It would be interesting to know if the 2.4.21 CPU load problem is related 
> > to the EHCI driver or the usb-storage driver.
> 
> Likely it's some kind of bad interaction, possibly related
> to those larger-capacity drives.   I don't recall it being
> a true CPU load -- more of a "too much time in i/o wait
> states" problem.

Maybe.  By the way, do you know whether that device-state-after-reset 
fix I sent in last week is also needed in 2.4.21?

> > I'm still planning to add non-verbose error logging to usb-storage.  But 
> > the are other things ahead of it.  It'll get it there eventually.
> 
> I might be able to dig up that patch I sent a while ago, which
> did that as well as laying the groundwork to use the driver model
> message framework.  Key parts of the work are already done, and
> only need updating to match recent kernels.

No need, I've still got the original version of that patch.  I just 
haven't gotten around to integrating it yet, and a number of other things 
have changed in the meantime.

Alan Stern



-------------------------------------------------------
This SF.net email is sponsored by: eBay
Get office equipment for less on eBay!
http://adfarm.mediaplex.com/ad/ck/711-11697-6916-5
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to