Greg KH wrote:

On Thu, Jun 12, 2003 at 09:12:00AM -0400, David T Hollis wrote:


Few minor code tweaks, formatting, etc. Greg, is this in proper shape for inclusion?



Close, but I think this will break on 2.4.22-pre1, right:


+#if LINUX_VERSION_CODE > KERNEL_VERSION(2,4,22)
+#include <linux/crc32.h>
+#else /* for now, this is swiped out of various drivers in drivers/net/... */
+static unsigned const ethernet_polynomial = 0x04c11db7U;
+static inline u32 ether_crc(int length, unsigned char *data)
+{
+ int crc = -1;
+ while (--length >= 0) {
+ unsigned char current_octet = *data++;
+ int bit;
+ for (bit = 0; bit < 8; bit++, current_octet >>= 1) {
+ crc = (crc << 1) ^
+ ((crc < 0) ^ (current_octet & 1) ?
+ ethernet_polynomial : 0);
+ }
+ }
+ return crc;
+}
+#endif



Can you also rip this out of the 2.5 version you sent me?


thanks,

greg k-h


Sure thing. When I was testing that on 2.4, it seems there are some things in flux with the CRC bits. I wasn't able to build and operate with the core internal one so I continued to use the one in the driver itself. I figured this helps for it to "just work" for other folks. I'll see what I can do to have it cleaned up and how it should be.



-------------------------------------------------------
This SF.NET email is sponsored by: eBay
Great deals on office technology -- on eBay now! Click here:
http://adfarm.mediaplex.com/ad/ck/711-11697-6916-5
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to