On Mon, Aug 11, 2003 at 03:35:53PM -0700, David Brownell wrote:
> Unfortunately, usb_set_configuration() is widely mis-used as a
> lightweight device reset.  That's trouble because setting a
> configuration must sometimes involve things that don't relate
> at all to a light reset, and can't be done in contexts like
> driver probe() calls.
> 
> This patch updates most usb_set_configuration() users to use a call
> that provides more appropriate functionality:
> 
>  - Adds a new usb_reset_configuration() call, which never needs
>    to change very much usbcore state.
> 
>  - Uses it to replace most usb_set_configuration() calls, in
>    many serial drivers, hisax, dvb, irda, and so on.
> 
>  - Modifies usb_reset_device() so it issues the control request
>    directly.  It's both more of a reset (hides a USB reset) and
>    less of one (altsettings are unchanged).
> 
>  - Makes usbfs return the error code instead of discarding it.
> 
> Once this goes in, then usb_set_configuration() can be made to
> work properly (including from sysfs).
> 
> Unfortunately I can't test this change (beyond compilation),
> since I don't have any of these devices.  Please verify that
> this works, and merge if it does.

Looks good.  I've tested it and it works with the devices I have.
Applied.

greg k-h


-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to