Hi,

I just heard back from Prolific through iTegno, and I was given no
information about the write requests except that they are reserved
registers.  However, the conclusion is that these write requests should
not be there as the driver should not change reserved registers.

Please verify this change with other PL2303 chip users, and hopefully
include in the mainstream USB tree.

thanks,
Eli

--- >8 ---
diff -u -r1.1.1.2 pl2303.c
--- drivers/usb/serial/pl2303.c 2003/05/13 04:14:35 1.1.1.2
+++ drivers/usb/serial/pl2303.c 2003/07/31 04:05:45
@@ -265,13 +265,6 @@
  dbg ("0xa1:0x21:0:0  %d - %x %x %x %x %x %x %x", i,
       buf[0], buf[1], buf[2], buf[3], buf[4], buf[5], buf[6]);

-
- i = usb_control_msg (serial->dev, usb_sndctrlpipe (serial->dev, 0),
-        VENDOR_WRITE_REQUEST, VENDOR_WRITE_REQUEST_TYPE,
-        0, 1, NULL, 0, 100);
-
- dbg ("0x40:1:0:1  %d", i);
-
  if (cflag & CSIZE) {
   switch (cflag & CSIZE) {
    case CS5: buf[6] = 5; break;
@@ -405,9 +398,6 @@
  SOUP (VENDOR_WRITE_REQUEST_TYPE, VENDOR_WRITE_REQUEST, 0x0404, 1);
  FISH (VENDOR_READ_REQUEST_TYPE, VENDOR_READ_REQUEST, 0x8484, 0);
  FISH (VENDOR_READ_REQUEST_TYPE, VENDOR_READ_REQUEST, 0x8383, 0);
- SOUP (VENDOR_WRITE_REQUEST_TYPE, VENDOR_WRITE_REQUEST, 0, 1);
- SOUP (VENDOR_WRITE_REQUEST_TYPE, VENDOR_WRITE_REQUEST, 1, 0xc0);
- SOUP (VENDOR_WRITE_REQUEST_TYPE, VENDOR_WRITE_REQUEST, 2, 4);

  /* Setup termios */
  if (port->tty) {




----- Original Message ----- 
From: "Greg KH" <[EMAIL PROTECTED]>
To: "Eli Chen" <[EMAIL PROTECTED]>
Cc: <[EMAIL PROTECTED]>
Sent: Friday, August 01, 2003 8:10 PM
Subject: Re: [linux-usb-devel] [PATCH] pl2303.c: fixed "device not
accepting new address" on reboot


> On Thu, Jul 31, 2003 at 05:32:21PM -0700, Eli Chen wrote:
> >
> > Question to Greg KH or anyone:
> > Could someone tell me what these magic messages are supposed to do, so
I
> > can make sure I didn't break anything?  Thanks,
>
> I don't know what they do, sorry.  They were added by the original
> "anonymous" author and seem to work for everyone else who has used this
> driver.
>
> If they break your device, I'd be a bit interested in why they do.  Do
> you have the specs for the chip?  We can always try to make a config
> option to let your device work...
>
> thanks,
>
> greg k-h
>




-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to