On Tue, Sep 16, 2003 at 07:53:45PM +0100, Daniel Drake wrote: > This patch makes more device drivers (listed below) send debug output to > the system log when CONFIG_USB_DEBUG is set in the kernel configuration. > > class/bluetty > class/usblp > core/hcd > image/microtek > input/hid-core > media/dabusb > media/vicam > net/ax8817x
No, for different reasons, the authors of these files did not want debug messages to be tied to CONFIG_USB_DEBUG. Traditionally CONFIG_USB_DEBUG only enabled debugging in the USB core code, although it looks like a few other drivers do tie their debugging messages to this setting (konicawc.c, usbnet.c, usbtest.c, and the usb-skeleton.c driver.) So I'm not going to take that part of the patch. > There are issues with some of the code that is now 'revealed' when > CONFIG_USB_DEBUG is now set. usblp, dabusb, and vicam *will not compile* > after this patch has been applied (and CONFIG_USB_DEBUG is set) presumably > because the now-revealed debug code has been copied over from the 2.4 > driver (and not updated). I have made additional patches to correct these > compile errors (which will come in followup mails shortly). > There was one compile error relating to dabusb.c which I could not see how > to fix. I commented that line out, and that commenting out is included in > the patch in this mail. Yes, any patches to fix breakages when debugging is enabled is fine to send (like the others that you sent.) If you want to resend those (after you un-linewrap them) and break out the dabusb.c patch below, I'd be glad to take them. thanks, greg k-h ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
