I have no real objection, tho someone should go back and test this without the US_FL_FIX_INQUIRY to see if the new scsi_scan.c code fixes this.
Matt
On Thu, Sep 25, 2003 at 11:23:24AM -0400, Alan Stern wrote:
> On Wed, 24 Sep 2003, Phil Dibowitz wrote:
>
> > My kernel asked me to send this to this address, so I am. =) 2.6.0-test5.
> >
> > Sep 24 23:12:34 rider kernel: usb-storage: This device (07cf,1001,5010 S
> > 05 P 01) has unneeded SubClass and Protocol entries in unusual_devs.h
> > Sep 24 23:12:34 rider kernel: Please send a copy of this message to
> > <[EMAIL PROTECTED]>
>
> Thanks for sending this in.
>
> The patch below should fix things. Because of the immediately preceding
> comment in unusual_devs.h, I made this a conservative change. Matt, any
> objections to doing it this way?
>
> If not, Greg please apply to 2.4 and 2.6.
>
> Alan Stern
>
>
> ===== unusual_devs.h 1.69 vs edited =====
> --- 1.69/drivers/usb/storage/unusual_devs.h Thu Sep 18 17:13:27 2003
> +++ edited/drivers/usb/storage/unusual_devs.h Thu Sep 25 11:17:23 2003
> @@ -542,10 +542,16 @@
> * - They don't like the INQUIRY command. So we must handle this command
> * of the SCSI layer ourselves.
> */
> -UNUSUAL_DEV( 0x07cf, 0x1001, 0x1000, 0x9009,
> +UNUSUAL_DEV( 0x07cf, 0x1001, 0x1000, 0x5009,
> "Casio",
> "QV DigitalCamera",
> US_SC_8070, US_PR_CB, NULL,
> + US_FL_FIX_INQUIRY ),
> +
> +UNUSUAL_DEV( 0x07cf, 0x1001, 0x5010, 0x9009,
> + "Casio",
> + "QV DigitalCamera",
> + US_SC_DEVICE, US_PR_DEVICE, NULL,
> US_FL_FIX_INQUIRY ),
>
> /* Submitted by Hartmut Wahl <[EMAIL PROTECTED]>*/
--
Matthew Dharm Home: [EMAIL PROTECTED]
Maintainer, Linux USB Mass Storage Driver
It was a new hope.
-- Dust Puppy
User Friendly, 12/25/1998
pgp00000.pgp
Description: PGP signature
