Hi,
somebody built his own version of be16_to_cpu(). Such things affect
maintainability.
Regards
Oliver
You can import this changeset into BK by piping this whole message to:
'| bk receive [path to repository]' or apply the patch as usual.
===================================================================
[EMAIL PROTECTED], 2003-11-21 21:56:40+01:00, [EMAIL PROTECTED]
- use correct big <-> little endian conversions from library
usblp.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -Nru a/drivers/usb/class/usblp.c b/drivers/usb/class/usblp.c
--- a/drivers/usb/class/usblp.c Fri Nov 21 21:59:27 2003
+++ b/drivers/usb/class/usblp.c Fri Nov 21 21:59:27 2003
@@ -1093,7 +1093,7 @@
/* First two bytes are length in big-endian.
* They count themselves, and we copy them into
* the user's buffer. */
- length = (usblp->device_id_string[0] << 8) + usblp->device_id_string[1];
+ length = be16_to_cpu(*((u16 *)usblp->device_id_string));
if (length < 2)
length = 2;
else if (length >= USBLP_DEVICE_ID_SIZE)
===================================================================
This BitKeeper patch contains the following changesets:
1.1128
## Wrapped with gzip_uu ##
begin 664 bkpatch9356
M'XL(`*]\OC\``\V47V^;,!3%G^-/<:6^)*T`7T,,84O4K9VV:9,69>[EMAIL PROTECTED]
M004<V295)3[\7#*UZ[0T^_<P0,+RL0^<>W_R"5Q99?*!KLJ=,N0$WFGK\H$?
MUVVAFK!1[4U;A]JLO;;0VFO11M<JVF^(OABE;.24=8P3OV0NG-R`5VP^P#!^
MF'%W6Y4/%F_>7GU\M2!D.H6+C6C6ZK-R,)T2I\U.5(4]%VY3Z29T1C2V5DZ$
M4M?=P]*.4<K\/<8TIF/>(:=)VDDL$$6"JJ`LR7A"]O]V_I,03ZUB1(:8Q4B3
MCO*,9>02,/23&=`X0HP8`L-\S/.$GE',*87#UG"&$%#R&[EMAIL PROTECTED](8#6*I#:
M&"4=K,HUO`QF4)7.50I44Y2B\6IS7_52-Q:NC:Z]O#+"W)$/P+,X(_/'@I/@
M-R]"J*!D=B198>Y+8Z/6KJ*M*1NG3"B_2YE03+LDH\BZ<8KB>K):B4F2<C5Y
MKJQ/;&4E;#^JMGOKOH/>G;-)%_,,[EMAIL PROTECTED](9[#[G@(CR$=LR[.$D9[
M##G[$4(V^34(\7^$<-^=3Q"8V_[Q5,T/-^H/$+U$.N&`Y/VW]Z!2S=IM8`HK
MA7SI]%)NV^'I<[EMAIL PROTECTED]@5JA=*=6R+);6^7:O1Z,7C\>8W"AY8]MZ*C`6
.Z=B?<%\!.KD!<"\%````
`
end
-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive? Does it
help you create better code? SHARE THE LOVE, and help us help
YOU! Click Here: http://sourceforge.net/donate/
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
