On Sat, 2003-12-27 at 12:11, Johannes Erdfelt wrote: > Complain to the manufacturer? If the descriptor really is less than 2 > bytes, then it certainly is invalid.
I really doubt the manufacturer would do anything since I am using Linux. Plus, I can't find an e-mail address or a phone number for them. > Was that portion of the patch you attached necessary? > > Or do you only need the patch to check for the descriptor type? If I just commented out "header->bDescriptorType == USB_DT_DEVICE", then it would fail with the warning "invalid descriptor of length 1". That's why I removed the check for the descriptor being less than 2 bytes. I don't know anything about the USB protocol. I just removed some stuff to make it work for me. I find it kind of interesting that there were no warnings for the game pad when using it on either a 2.4.23 or a 2.6.0-test5 kernel if the device is sending an invalid descriptor. The description of the patch that made the game pad not work says that it only moves all of the descriptor length and type checking to one place. I would argue that it does more than move code since it causes my device to stop working. Anyway, I'm just trying to inform the developers that there might be something wrong with the descriptor length and type checking code. Of course, like you said, maybe this device doesn't conform to the USB specs. Ashley ------------------------------------------------------- This SF.net email is sponsored by: IBM Linux Tutorials. Become an expert in LINUX or just sharpen your skills. Sign up for IBM's Free Linux Tutorials. Learn everything from the bash shell to sys admin. Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
