ChangeSet 1.1504.2.9, 2003/12/08 16:54:38-08:00, [EMAIL PROTECTED]
[PATCH] USB: khubd optimization
It changes spin_lock_save() to spin_lock() within the completion routine
and list_del()/INIT_LIST_HEAD() to list_del_init(). It's nothing more
than a minor optimization.
drivers/usb/core/hub.c | 11 ++++-------
1 files changed, 4 insertions(+), 7 deletions(-)
diff -Nru a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
--- a/drivers/usb/core/hub.c Mon Dec 29 14:26:01 2003
+++ b/drivers/usb/core/hub.c Mon Dec 29 14:26:01 2003
@@ -126,7 +126,6 @@
static void hub_irq(struct urb *urb, struct pt_regs *regs)
{
struct usb_hub *hub = (struct usb_hub *)urb->context;
- unsigned long flags;
int status;
switch (urb->status) {
@@ -151,12 +150,12 @@
hub->nerrors = 0;
/* Something happened, let khubd figure it out */
- spin_lock_irqsave(&hub_event_lock, flags);
+ spin_lock(&hub_event_lock);
if (list_empty(&hub->event_list)) {
list_add(&hub->event_list, &hub_event_list);
wake_up(&khubd_wait);
}
- spin_unlock_irqrestore(&hub_event_lock, flags);
+ spin_unlock(&hub_event_lock);
resubmit:
if ((status = usb_submit_urb (hub->urb, GFP_ATOMIC)) != 0
@@ -494,10 +493,8 @@
spin_lock_irqsave(&hub_event_lock, flags);
/* Delete it and then reset it */
- list_del(&hub->event_list);
- INIT_LIST_HEAD(&hub->event_list);
- list_del(&hub->hub_list);
- INIT_LIST_HEAD(&hub->hub_list);
+ list_del_init(&hub->event_list);
+ list_del_init(&hub->hub_list);
spin_unlock_irqrestore(&hub_event_lock, flags);
-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills. Sign up for IBM's
Free Linux Tutorials. Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id78&alloc_id371&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
