ChangeSet 1.1504.2.42, 2003/12/12 09:35:24-08:00, [EMAIL PROTECTED]

[PATCH] USB: don't send any MODE SENSE commands to usb mass storage devices

This patch basically eliminates the use of MODE_SENSE or MODE_SENSE_10 for
direct-access USB storage devices.  That $&%*! command has caused us more
trouble than all the others combined, and after more than a year we still
don't have a good way of handling/using them.

I constantly get complaints about devices which don't work because of the
way 2.5/6 uses MODE_SENSE and MODE_SENSE_10 -- this patch will greatly
increase compatiblity with devices.  As with the patch to limit transfer
sizes, I'd like to see this applied as soon as possible.

Matt

> ----- Forwarded message from Patrick Mansfield <[EMAIL PROTECTED]> -----
>
> Date: Thu, 20 Nov 2003 08:28:27 -0800
> From: Patrick Mansfield <[EMAIL PROTECTED]>
> Subject: [PATCH] don't send any MODE SENSE commands to usb mass storage devices
> To: [EMAIL PROTECTED]

Matthew -

Is this patch in your queue? I don't see it in Linus' tree yet.

Don't send any MODE SENSE commands to usb mass storage devices.


 drivers/usb/storage/scsiglue.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)


diff -Nru a/drivers/usb/storage/scsiglue.c b/drivers/usb/storage/scsiglue.c
--- a/drivers/usb/storage/scsiglue.c    Mon Dec 29 14:22:19 2003
+++ b/drivers/usb/storage/scsiglue.c    Mon Dec 29 14:22:19 2003
@@ -325,7 +325,8 @@
        .emulated =                     TRUE,
 
        /* modify scsi_device bits on probe */
-       .flags = (BLIST_MS_SKIP_PAGE_08 | BLIST_USE_10_BYTE_MS),
+       .flags = (BLIST_MS_SKIP_PAGE_08 | BLIST_MS_SKIP_PAGE_3F |
+                 BLIST_USE_10_BYTE_MS),
 
        /* module management */
        .module =                       THIS_MODULE



-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills.  Sign up for IBM's
Free Linux Tutorials.  Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id78&alloc_id371&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to