Hi Dave,
> It reads well. Presumably you tested with usbfs and the ALSA sound
> driver?
I have never managed to get my only usb sound device working. So I can't
test if sound goes in and out OK. But I can connect/disconnect without Oops.
I tested usbfs of course. It shouldn't be applied without my other usbfs
fixes (see later patches) otherwise you get deadlocks (proc_setconfig causes
disconnect to be called and hangs because of the wrong lock order etc).
> And I see you added "dev->serialize" to the list of locks
> that the claim/release calls must hold ... probably safer to do that,
> though I suspect that at least the release() requirement can vanish.
But release causes disconnect to be called. dev->serialize should be
held during a disconnect() call, right?
> Also I'd revert the change to create the driverfs interface files
> after all the probes succeed; it already makes trouble with hotplug
> (and sometimes udev) to have delays before those files appear, and
> this lengthens the delays.
The reason for this change was that the "name" device field wasn't
set up for all interfaces when usb_claim_interface was being called on
all interfaces by the usb audio probe() method. This caused sysfs to
barf when it created a link to a NULL name. So the important part
was to set up all names before calling any device_add. I moved the
usb_create_driverfs_intf_files (intf);
down too, because it was after driver_add before and I assumed it
wouldn't work before device_add.
> I'll give this a whirl; drivers/usb/class/{audio,cdc-acm}.c also
> need changes, but this is a good start.
OK.
Duncan.
-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills. Sign up for IBM's
Free Linux Tutorials. Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
