On Mon, Jan 12, 2004 at 11:53:48AM -0800, Greg KH wrote: > On Sun, Jan 11, 2004 at 03:29:44PM -0800, Matthew Dharm wrote: > > This patch (from Alan Stern as157) fixes the non-READ/WRITE paths of the > > sddr09.c driver to be compliant to the requirements of scatter-gather. It > > also cleans up MODE_SENSE processing and reports errors a little better. > > > > This patch also makes MODE_SENSE_10 commands report an error. The old code > > claimed to support both 6- and 10-byte versions, but really only supported > > 6-byte. Bad data was returned for the 10-byte case, so it was removed. A > > patch to follow in a few minutes fixes this. > > Ok, due to the complaints about this patch, I'll wait for you to send me > a new one.
The complaints are probably valid, but they're really stylistic, not
functional. The current code isn't functional, and these patches will fix
it.
I think both the sddr09 and sddr55 patches should go in.
Matt
--
Matthew Dharm Home: [EMAIL PROTECTED]
Maintainer, Linux USB Mass Storage Driver
Umm, these aren't the droids you're looking for.
-- Bill Gates
User Friendly, 11/14/1998
pgp00000.pgp
Description: PGP signature
