Hi, I'm currently working to correct the locking problems in the LEGO USB Tower driver. In the course of that I've read through the current version of usb-skeleton.c in 2.6.3, and I have a few questions and remarks:
- Parallel read and write are impossible due to locking on dev->sem. Is that ok? If not, is there a standard way to fix it? This one is bothering me most, as it is currently the same in the LEGO USB Tower driver. - Read and write aren't interruptible and don't support nonblocking I/O. How important is it to support nonblocking I/O? - It would be nice to use a bigger buffer size than the packet size as that is typical. - Shouldn't seeking be forbidden by adding an llseek method that forbids seeking by returning -ESPIPE? - I suppose __FUNCTION__ should be replaced by __func__. - The module use count is decremented after release, not before as written in the comment at line 151. Any opinions? J�rgen -- J�rgen Stuber <[EMAIL PROTECTED]> http://www.loria.fr/~stuber/ ------------------------------------------------------- SF.Net is sponsored by: Speed Start Your Linux Apps Now. Build and deploy apps & Web services for Linux with a free DVD software kit from IBM. Click Now! http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
