Hi Greg,
you are using an irqsave spinlock in a completion handler. Not actually
wrong but it tends to confuse people about the context the function is
executed under.
Regards
Oliver
You can import this changeset into BK by piping this whole message to:
'| bk receive [path to repository]' or apply the patch as usual.
===================================================================
[EMAIL PROTECTED], 2004-03-22 21:56:31+01:00, [EMAIL PROTECTED]
- use simple spinlock in irq handler
belkin_sa.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff -Nru a/drivers/usb/serial/belkin_sa.c b/drivers/usb/serial/belkin_sa.c
--- a/drivers/usb/serial/belkin_sa.c Mon Mar 22 22:13:45 2004
+++ b/drivers/usb/serial/belkin_sa.c Mon Mar 22 22:13:45 2004
@@ -271,7 +271,6 @@
struct usb_serial *serial;
unsigned char *data = urb->transfer_buffer;
int retval;
- unsigned long flags;
switch (urb->status) {
case 0:
@@ -302,7 +301,7 @@
/* ignore data[0] and data[1] */
priv = usb_get_serial_port_data(port);
- spin_lock_irqsave(&priv->lock, flags);
+ spin_lock(&priv->lock);
priv->last_msr = data[BELKIN_SA_MSR_INDEX];
/* Record Control Line states */
@@ -350,7 +349,7 @@
}
}
#endif
- spin_unlock_irqrestore(&priv->lock, flags);
+ spin_unlock(&priv->lock);
exit:
retval = usb_submit_urb (urb, GFP_ATOMIC);
if (retval)
===================================================================
This BitKeeper patch contains the following changesets:
1.1187
## Wrapped with gzip_uu ##
begin 664 bkpatch13965
M'XL(``E77T```[6486N<0!"&/]_^BH%`:0GJ[+JKI\60-BEI::''M?E42O!T
M>R>GZ]75*P5_?$>/7!I(<]>2JC"+,SL[[\RC)W!M=1-/ZK+8ZH:=P-O:MO&$
MUE67:^,:W:V[RJV;)?GF=4T^;U57VMMM\#XW6ENO+$QG'>$J1E&SM,U60$X;
M3[CK[]^T/S<ZGLS?7%U_>[EMAIL PROTECTED]:[EMAIL PROTECTED];--BUS>YZVJ[(V;MND
MQE:Z3=VLKOI]:"\0!=V*ASZJH.<!RK#/>,YY*KG.4<AI(-FNO/,'=-Q/)=$7
M`D,1HNP#]'G$+H&[EMAIL PROTECTED]<JB'U^BCQ&A#^GAE,.#K+7\+1:+E@&
[EMAIL PROTECTED]&"B:[T#Y\I*F]QX"#&3(9G>=9<Y?7HQABNSL@(2\
M&[EMAIL PROTECTED]<XN/.*G2$MOH<MU86XL!?RF2R(/>T'Z1,^C,.(ZE8LH#T0V?:R11^0?
M!T='*!GUOA)3,1+U^+[#F#V%KEOV[N1\639Z^?4H491><*FDZB4JY".-$N^S
MJ&(9'<&B`,?_7RP:HW6N\X$^FV[U`.(ME$3A;[EMAIL PROTECTED]
M$JA#5"Z9=SLS&<JX&>IX_FQ#)[EMAIL PROTECTED](W/^OLI7.UK:K
1$J[HH\)ODOT"*$'(OBT%````
`
end
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
