On Thu, 25 Mar 2004, Pete Zaitcev wrote: > > > > usb-storage: This device (05dc,b002,0113 S 06 P 50) has unneeded > > > > SubClass and Protocol entries in unusual_devs.h > > > > Please send a copy of this message to <[EMAIL PROTECTED]> > > > > Greg and Pete, please apply this patch to both 2.6 and 2.4. > > > > Applied to 2.6, thanks. > > Alan, what are implications of not applying this? As long as we force > protocol and transport right, device continues to work, isn't it right? > > -- Pete
That's right, the device will work. The driver will also continue to log the message you see at the top of this email. The purpose of the change is really to document in the source file exactly which fields are needed to override a value supplied by the device and which are merely placeholders. That way, as we continue to improve the driver, we can eliminate unusual_devs entries that contain nothing but placeholders (no overrides). Without some scheme of this sort we would have no way of recognizing entries that do nothing useful. Just in case it's not obvious, the driver emits the log messages because we developers don't have most of the devices listed in the file, so we have no way to tell which fields are needed and which aren't. With the help of the user community, we are slowly but surely improving that situation. As a matter of policy, Matt, Greg, and I have been keeping the 2.4 and 2.6 versions of unusual_devs.h identical. That means including some entries in the 2.6 version which are superfluous there but are needed in 2.4. However the benefit from not having to worry about two different versions of the file more than makes up for the wasted space. I always imagined we would let the 2.7 version begin to diverge from the earlier ones. Unless you have strong feelings about this, there doesn't seem to be any reason to change the current policy. Alan Stern ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
