On Fri, Apr 30, 2004 at 11:04:24AM +0200, Duncan Sands wrote: > On Tuesday 27 April 2004 10:58, Oliver Neukum wrote: > > Am Dienstag, 27. April 2004 00:14 schrieb Greg KH: > > > On Mon, Apr 26, 2004 at 04:05:17PM +0200, Duncan Sands wrote: > > > > diff -Nru a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c > > > > --- a/drivers/usb/core/devio.c Mon Apr 26 13:48:28 2004 > > > > +++ b/drivers/usb/core/devio.c Mon Apr 26 13:48:28 2004 > > > > @@ -350,8 +350,8 @@ > > > > * all pending I/O requests; 2.6 does that. > > > > */ > > > > > > > > - if (ifnum < 8*sizeof(ps->ifclaimed)) > > > > - clear_bit(ifnum, &ps->ifclaimed); > > > > + BUG_ON(ifnum >= 8*sizeof(ps->ifclaimed)); > > > > > > I've changed that to a WARN_ON(). Yeah, writing over memory is bad, but > > > oopsing is worse. Let's be a bit nicer than that. > > > > You aren't nice that way. An oops has localised consequences. Scribbling > > over memory can cause anything. > > Hi Greg, if won't accept a BUG_ON, how about the following?
Fine with me, applied, thanks. greg k-h ------------------------------------------------------- This SF.Net email is sponsored by: Oracle 10g Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE. http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
