Hi,

this was buggy for the same reason that the old msleep was buggy.

        Regards
                Oliver

You can import this changeset into BK by piping this whole message to:
'| bk receive [path to repository]' or apply the patch as usual.

===================================================================


[EMAIL PROTECTED], 2004-05-19 17:33:11+02:00, [EMAIL PROTECTED]
  - safe waiting in case we are left on other wait queues


 kaweth.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)


diff -Nru a/drivers/usb/net/kaweth.c b/drivers/usb/net/kaweth.c
--- a/drivers/usb/net/kaweth.c  Wed May 19 17:33:39 2004
+++ b/drivers/usb/net/kaweth.c  Wed May 19 17:33:39 2004
@@ -1240,20 +1240,20 @@
         init_waitqueue_head(&awd.wqh);
         awd.done = 0;
 
-        set_current_state(TASK_INTERRUPTIBLE);
         add_wait_queue(&awd.wqh, &wait);
         urb->context = &awd;
-        status = usb_submit_urb(urb, GFP_ATOMIC);
+        status = usb_submit_urb(urb, GFP_NOIO);
         if (status) {
                 // something went wrong
                 usb_free_urb(urb);
-                set_current_state(TASK_RUNNING);
                 remove_wait_queue(&awd.wqh, &wait);
                 return status;
         }
 
-       while (timeout && !awd.done)
+       while (timeout && !awd.done) {
+               set_current_state(TASK_UNINTERRUPTIBLE);
                timeout = schedule_timeout(timeout);
+       }
 
         set_current_state(TASK_RUNNING);
         remove_wait_queue(&awd.wqh, &wait);

===================================================================


This BitKeeper patch contains the following changesets:
1.1754
## Wrapped with gzip_uu ##


M'XL( %-^JT   \U4;6O;,!#^;/V*&X72TL669#F./3+ZNBZTM"%-/HT1%/L:
MF\1V*\D-8]Y_GYR4EFX+96.#R3:'?*?G[IY[T Y,-*K8J9;Y RJR Q\K;6*G
MD,D,3>:66"_JPJW4W+I&565=7E85Z&WBO;%"U-Y<X9QWB0T92I-D8#TZ=ICK
M/_TQ7^XP=D9GYY/+HQ$A_3Z<9+*<XPT:Z/>)J=2#7*;Z4)IL696N4;+4!1KI
M)E71/(4VG%)NGX"%/@VZ#>M2$38)[EMAIL PROTECTED]>AU!=G4=OAS#R^1A,6)6&#A
MHH9WH\ GI\!<[EMAIL PROTECTED]"J/!HX+$(6!C[?LS8 >4QI; 5&0X8="@YAK_;R0E)H -:
MWB*L9&[R<@YY"[EMAIL PROTECTED]<(2;PU4)[EMAIL PROTECTED]::]3D [EMAIL 
PROTECTED](I\,GZDFG=]<
MA%!)R7NX:X?XZY92U5*BO5K/O(5<M;0D3]UQRBBE#>M%W&]F&$DAZ.U,I&E"
[EMAIL PROTECTED],>Q^9:WQA=!U%O+:=N)5EW_I'K2BOYPH2J9M4B?VNWG5PMG
MK.?;U?AA%(1KO07!CVJCP>MJ$] 1_YG:-K.XAHY:K5^KGN'6L?R!$D\9%SZP
MM>U:.WBT\+BTD:;6T >;:ZKK69&;::UF>_9["^<?AM.KZ\'U_KOV?$ W.);[
M-8ZUG#BK+%\B[)F\P*HVL+L+;^0J==.JQ'WX2AQ'HYDFM5)8FFF;#??&1S<7
MT\G5X&I\-AI-AN/!\>693=%"MJ4YWY[OQ"3#9*'KHH]<!CV>IN0[XV[4*WL%
"    


-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to